Change localization back to main #7072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
jeffhandley,
sharwell,
ViktorHofer,
ericstj,
mavasani,
cristianosuzuki77 and
buyaa-n
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7072 +/- ##
==========================================
- Coverage 96.43% 96.43% -0.01%
==========================================
Files 1412 1412
Lines 336968 336968
Branches 11143 11143
==========================================
- Hits 324946 324941 -5
- Misses 9218 9224 +6
+ Partials 2804 2803 -1 |
mavasani
approved these changes
Dec 8, 2023
|
/backport to release/8.0.2xx |
|
Started backporting to release/8.0.2xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/7137309931 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we shipped 8.0.1xx, we need to revert localization back to point to main. I already opened the internal issue for the loc team to track this request.
Here is the old PR that temporarily moved main to 8.0.1xx: https://github.com/dotnet/roslyn-analyzers/pull/6890/files
Question: This change was also backported to the 8.0.1xx branch. Do I also need to revert the change in that branch, or can that one stay as is?
Edit: Answer: I need to backport it to release/8.0.2xx. I don't think I should backport it to 8.0.1xx, that branch won't be active again.