Add CollectionExpression support to CA1870 (UseSearchValues) #7252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup after #6898 to add recognition for collection expression patterns as well.
Currently, if you write something like
you will be offered two fixers: one to replace
s_chars
withSearchValues.Create("aeiouA")
, and the other to replace the array creation with['a', 'e', 'i', 'o', 'u', 'A']
.If you accept the latter, you won't be offered the
SearchValues
fixer anymore since we don't recognize the pattern.This PR adds recognition for patterns like