[release/9.0.1xx] Update field references #7432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@cston can you please fill out the template and send an email to Tactics requesting an approval to merge? And I left a question in the original PR but also asking it here: Should we snap a release/9.0.2xx branch and merge it there too? SDK already has such branch, we haven't snapped one here yet. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/9.0.1xx #7432 +/- ##
================================================
Coverage 96.49% 96.49%
================================================
Files 1443 1443
Lines 345885 345885
Branches 11374 11374
================================================
Hits 333757 333757
Misses 9245 9245
Partials 2883 2883 |
jaredpar
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7430 to release/9.0.1xx
With the .NET 9 C# compiler, when compiling with
-langversion:preview,fieldreferences within property accessors are treated as referring to a synthesized backing field for the property rather than another symbol namedfieldthat may be in scope.The change here is to rename existing locals to retain the original intent.
/cc @cston
Customer Impact
No expected customer impact.
Testing
Risk
Low. The change is renames of locals only.