Provide an extensibility point in AnalyzerTest for sorting diagnostics. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sort here is non-deterministic for any analyzers whose diagnostics can differ only on the message format and properties. Allow the sorting algorithm to be changed by the user to include either or both of these elements if they emit diagnostics that differ only on these values from a concurrent analyzer (the .NET Interop team owns an analyzer like this, which prompted this work). This will ensure that everyone can ensure that their diagnostic and code-fix tests (which rely on the ordering to determine the order for the iterative code-fix tests and the fix-all tests) are deterministic.
mavasani
approved these changes
Aug 3, 2022
mavasani
reviewed
Aug 3, 2022
src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort here is non-deterministic for any analyzers whose diagnostics can differ only on the message format and properties.
Allow the sorting algorithm to be changed by the user to include either or both of these elements if they emit diagnostics that differ only on these values from a concurrent analyzer (the .NET Interop team owns an analyzer like this, which prompted this work). This will ensure that everyone can ensure that their diagnostic and code-fix tests (which rely on the ordering to determine the order for the iterative code-fix tests and the fix-all tests) are deterministic.
cc: @sharwell