Update ReleaseHandle to check return values

dotnet · Apr 16, 2020 · 39c31e3 · 39c31e3
1 parent 4188058
commit 39c31e3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Workspaces/Core/Portable/Storage/SQLite/v1/Interop/SafeSqliteBlobHandle.cs b/src/Workspaces/Core/Portable/Storage/SQLite/v1/Interop/SafeSqliteBlobHandle.cs
@@ -18,8 +18,8 @@ public SafeSqliteBlobHandle(SafeSqliteHandle sqliteHandle, sqlite3_blob? wrapper
 
         protected override bool ReleaseChildHandle()
         {
-            raw.sqlite3_blob_close(Wrapper);
-            return true;
+            var result = (Result)raw.sqlite3_blob_close(Wrapper);
+            return result == Result.OK;
         }
     }
 }
diff --git a/src/Workspaces/Core/Portable/Storage/SQLite/v1/Interop/SafeSqliteHandle.cs b/src/Workspaces/Core/Portable/Storage/SQLite/v1/Interop/SafeSqliteHandle.cs
@@ -18,8 +18,8 @@ public SafeSqliteHandle(sqlite3? wrapper)
 
         protected override bool ReleaseHandle()
         {
-            raw.sqlite3_close(Wrapper);
-            return true;
+            var result = (Result)raw.sqlite3_close(Wrapper);
+            return result == Result.OK;
         }
     }
 }
diff --git a/src/Workspaces/Core/Portable/Storage/SQLite/v1/Interop/SafeSqliteStatementHandle.cs b/src/Workspaces/Core/Portable/Storage/SQLite/v1/Interop/SafeSqliteStatementHandle.cs
@@ -18,8 +18,8 @@ public SafeSqliteStatementHandle(SafeSqliteHandle sqliteHandle, sqlite3_stmt? wr
 
         protected override bool ReleaseChildHandle()
         {
-            raw.sqlite3_finalize(Wrapper);
-            return true;
+            var result = (Result)raw.sqlite3_finalize(Wrapper);
+            return result == Result.OK;
         }
     }
 }