do not fail tests in areas where workspace warnings are expected

dotnet · Nov 8, 2021 · 7395382 · 7395382
1 parent a927732
commit 7395382
Show file tree

Hide file tree

Showing 3 changed files with 111 additions and 85 deletions.
diff --git a/src/Workspaces/MSBuildTest/MSBuildWorkspaceTestBase.cs b/src/Workspaces/MSBuildTest/MSBuildWorkspaceTestBase.cs
@@ -151,10 +151,14 @@ protected async Task<Solution> SolutionAsync(params IBuilder[] inputs)
             }
         }
 
-        protected static MSBuildWorkspace CreateMSBuildWorkspace(params (string key, string value)[] additionalProperties)
+        protected static MSBuildWorkspace CreateMSBuildWorkspace(bool throwOnWorkspaceFailed = true, params (string key, string value)[] additionalProperties)
         {
             var workspace = MSBuildWorkspace.Create(CreateProperties(additionalProperties));
-            workspace.WorkspaceFailed += (s, e) => throw new Exception($"Workspace failure {e.Diagnostic.Kind}:{e.Diagnostic.Message}");
+            if (throwOnWorkspaceFailed)
+            {
+                workspace.WorkspaceFailed += (s, e) => throw new Exception($"Workspace failure {e.Diagnostic.Kind}:{e.Diagnostic.Message}");
+            }
+
             return workspace;
         }