Analyze properties with conditional attributes in patterns (#51001)

dotnet · Feb 10, 2021 · d8a22e5 · d8a22e5
1 parent 09c1881
commit d8a22e5
Show file tree

Hide file tree

Showing 4 changed files with 1,719 additions and 30 deletions.
diff --git a/src/Compilers/CSharp/Portable/FlowAnalysis/AbstractFlowPass_Switch.cs b/src/Compilers/CSharp/Portable/FlowAnalysis/AbstractFlowPass_Switch.cs
@@ -18,7 +18,7 @@ internal abstract partial class AbstractFlowPass<TLocalState, TLocalFunctionStat
         public override BoundNode VisitSwitchStatement(BoundSwitchStatement node)
         {
             // dispatch to the switch sections
-            var (initialState, afterSwitchState) = VisitSwitchStatementDispatch(node);
+            var afterSwitchState = VisitSwitchStatementDispatch(node);
 
             // visit switch sections
             var switchSections = node.SwitchSections;
@@ -36,7 +36,7 @@ public override BoundNode VisitSwitchStatement(BoundSwitchStatement node)
             return null;
         }
 
-        protected virtual (TLocalState initialState, TLocalState afterSwitchState) VisitSwitchStatementDispatch(BoundSwitchStatement node)
+        protected virtual TLocalState VisitSwitchStatementDispatch(BoundSwitchStatement node)
         {
             // visit switch header
             VisitRvalue(node.Expression);
@@ -77,7 +77,7 @@ protected virtual (TLocalState initialState, TLocalState afterSwitchState) Visit
                 Join(ref afterSwitchState, ref initialState);
             }
 
-            return (initialState, afterSwitchState);
+            return afterSwitchState;
         }
 
         /// <summary>

diff --git a/src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs b/src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
@@ -5117,6 +5117,12 @@ private void ApplyMemberPostConditions(BoundExpression? receiverOpt, MethodSymbo
                 return;
             }
 
+            ApplyMemberPostConditions(receiverSlot, method);
+        }
+
+        private void ApplyMemberPostConditions(int receiverSlot, MethodSymbol method)
+        {
+            Debug.Assert(receiverSlot >= 0);
             do
             {
                 var type = method.ContainingType;