Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum throws on Mono 64-bit #23722

Closed
DustinCampbell opened this issue Dec 11, 2017 · 1 comment
Closed

Checksum throws on Mono 64-bit #23722

DustinCampbell opened this issue Dec 11, 2017 · 1 comment
Assignees
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@DustinCampbell
Copy link
Member

Version Used: 2.6.0

The latest Roslyn release results in test failures in OmniSharp on Linux/OSX (failing build log: omnisharp-build-log.txt) that look so:

�[39;49m�[31m    OmniSharp.Roslyn.CSharp.Tests.RenameFacts.Rename_DoesNotUpdatesWorkspace [FAIL]
�[39;49m�[37m      System.AggregateException : One or more errors occurred.
�[39;49m�[37m      ---- System.ArgumentException : checksum must be a SHA-1 hash
�[39;49m�[37m      Parameter name: checksum
�[39;49m�[30m      Stack Trace:
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1+ConfiguredTaskAwaiter[TResult].GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at Microsoft.CodeAnalysis.FindSymbols.SyntaxTreeIndex+<GetChecksumAsync>d__53.MoveNext () [0x00087] in <82fd95a6d9bb4f6e9a2da5a34e8280f2>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---

<snip lots of async state machine transitions>

�[39;49m�[37m        ----- Inner Stack Trace -----
�[39;49m�[37m          at Microsoft.CodeAnalysis.Checksum..ctor (System.Byte[] checksum) [0x00031] in <82fd95a6d9bb4f6e9a2da5a34e8280f2>:0 
�[39;49m�[37m          at Microsoft.CodeAnalysis.Checksum.ComputeChecksum (System.IO.Stream stream, System.Security.Cryptography.IncrementalHash hash) [0x00042] in <82fd95a6d9bb4f6e9a2da5a34e8280f2>:0 
�[39;49m�[37m          at Microsoft.CodeAnalysis.Checksum.Create (System.IO.Stream stream) [0x0000b] in <82fd95a6d9bb4f6e9a2da5a34e8280f2>:0 
�[39;49m�[37m          at Microsoft.CodeAnalysis.Checksum.Create (Microsoft.CodeAnalysis.Serialization.WellKnownSynchronizationKind kind, Roslyn.Utilities.IObjectWritable object) [0x00024] in <82fd95a6d9bb4f6e9a2da5a34e8280f2>:0 
�[39;49m�[37m          at Microsoft.CodeAnalysis.ProjectInfo+ProjectAttributes.Microsoft.CodeAnalysis.IChecksummedObject.get_Checksum () [0x0000e] in <82fd95a6d9bb4f6e9a2da5a34e8280f2>:0 
�[39;49m�[37m          at Microsoft.CodeAnalysis.Serialization.Serializer.CreateChecksum (System.Object value, System.Threading.CancellationToken cancellationToken) [0x00028] in <82fd95a6d9bb4f6e9a2da5a34e8280f2>:0 
�[39;49m�[37m          at Microsoft.CodeAnalysis.ProjectState+<ComputeChecksumsAsync>d__111.MoveNext () [0x000ce] in <82fd95a6d9bb4f6e9a2da5a34e8280f2>:0 

It appears that this is due to a struct layout padding issue on Mono 64-bit, which was found and "fixed" by #22794, but not in master. This is currently blocking OmniSharp, and thus, VS Code from taking a new Roslyn and adding support for C# 7.2.

@jasonmalinowski
Copy link
Member

The fix we have in the refactorings branch will flow into master this week. If we do a fix sooner that's something other than a cherry-pick let me know as we'll have to resolve that then.

sharwell added a commit to sharwell/roslyn that referenced this issue Dec 12, 2017
@DustinCampbell DustinCampbell added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

4 participants