Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Strict] Diagnose precedence error with query expression #30231

Closed
gafter opened this issue Sep 29, 2018 · 1 comment · Fixed by #46239
Closed

[Strict] Diagnose precedence error with query expression #30231

gafter opened this issue Sep 29, 2018 · 1 comment · Fixed by #46239
Assignees
@gafter
Labels
Area-Compilers Bug Feature - Range Range Feature - Warning Waves Warning Waves Feature Request
Milestone
16.8

Comments

@gafter
Copy link
Member

gafter commented Sep 29, 2018

The following statement should be a syntax error because the query expression appears at the wrong precedence:

        int a = b + from c in d select c;

We correctly diagnose this error in "strict" more.

Please add this to a warning wave (possibly as an error?)
@gafter gafter added this to the Backlog milestone Feb 18, 2019
@gafter
Copy link
Member Author

gafter commented Jul 17, 2019

We have introduced this error in parsing the range operator .. too.

@gafter gafter added the Feature - Range Range label Jul 17, 2019
@gafter gafter modified the milestones: Backlog, 16.8 Jul 22, 2020
@gafter gafter self-assigned this Jul 22, 2020
gafter pushed a commit to gafter/roslyn that referenced this issue Jul 22, 2020
Diagnose precedence inversion in a warning wave
5c46c10 
Fixes dotnet#30231
@gafter gafter mentioned this issue Jul 23, 2020
Merged
@gafter gafter added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Jul 23, 2020
gafter pushed a commit that referenced this issue Jul 31, 2020
Diagnose precedence inversion in a warning wave (#46239)
b6cdd27 
Fixes #30231
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Bug Feature - Range Range Feature - Warning Waves Warning Waves Feature Request
Projects
None yet
Milestone
16.8
Development

Successfully merging a pull request may close this issue.

Diagnose precedence inversion in a warning wave gafter/roslyn
1 participant
@gafter