Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Workspace.OnWorkspaceFailed (breaking change) #40085

Closed
tmat opened this issue Dec 2, 2019 · 3 comments
Closed

Remove Workspace.OnWorkspaceFailed (breaking change) #40085

tmat opened this issue Dec 2, 2019 · 3 comments
Labels
Area-IDE Blocked Concept-API This issue involves adding, removing, clarification, or modification of an API.
Milestone
Backlog

Comments

@tmat
Copy link
Member

tmat commented Dec 2, 2019 •
edited
Loading

Document load failures are now captured on TextAndVersion, so this event is no longer needed.

Also remove Workspace parameter from TextLoader.LoadTextAndVersionAsync API and from MSBuildProjectLoader constructor.
@tmat tmat added this to the Backlog milestone Dec 2, 2019
@tmat tmat added the Area-IDE label Dec 2, 2019
@tmat tmat mentioned this issue Dec 2, 2019
Merged
@sharwell
Copy link
Member

sharwell commented Dec 3, 2019

We won't be able to remove the event itself, but we can stop using it at any time. Likewise, we cannot remove the Workspace parameter from LoadTextAndVersionAsync, but we can stop using it within the method.

@sharwell sharwell added Blocked Concept-API This issue involves adding, removing, clarification, or modification of an API. labels Dec 3, 2019
@tmat
Copy link
Member Author

tmat commented Dec 3, 2019

I disagree. We can certainly remove it. First, we mark it as obsolete and then we remove it in 4.0.0.

@tmat tmat mentioned this issue Jan 12, 2020
Merged
@CyrusNajmabadi
Copy link
Member

Closing out. This should go through API review.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Blocked Concept-API This issue involves adding, removing, clarification, or modification of an API.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@tmat @sharwell @CyrusNajmabadi