Document load failures #40044
Merged
Document load failures #40044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
WorkspaceDiagnostics2
branch
from
b55129d to
9408826
Compare
sharwell
reviewed
Dec 3, 2019
src/Workspaces/Core/Portable/Workspace/Solution/RecoverableTextAndVersion.cs
Show resolved
Hide resolved
.../Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.StateManager.HostStates.cs
Show resolved
Hide resolved
mavasani
reviewed
Dec 3, 2019
src/Workspaces/Core/Portable/Workspace/WorkspaceDiagnosticDescriptors.cs
Show resolved
Hide resolved
mavasani
reviewed
Dec 3, 2019
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Show resolved
Hide resolved
mavasani
approved these changes
Dec 3, 2019
tmat
force-pushed
the
WorkspaceDiagnostics2
branch
from
c5bb4c7 to
78db871
Compare
sharwell
reviewed
Dec 4, 2019
src/Workspaces/Core/Portable/Workspace/Solution/DocumentState.cs
Outdated
Show resolved
Hide resolved
tmat
force-pushed
the
WorkspaceDiagnostics2
branch
from
78db871 to
d3c91f5
Compare
sharwell
approved these changes
Dec 5, 2019
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Show resolved
Hide resolved
sharwell
approved these changes
Dec 6, 2019
RikkiGibson
added a commit
that referenced
this pull request
Dec 11, 2019
This reverts commit 6ac8006.
RikkiGibson
added a commit
that referenced
this pull request
Dec 12, 2019
Revert "Document load failures (#40044)"
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jan 8, 2020
tmat
added a commit
that referenced
this pull request
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes document content load failures part of the solution snapshot. The diagnostic is stored on
TextAndVersion. Previously these errors have only been reported via a workspace event. This change keeps that mechanism in place for backward compatibility until we can make a breaking change and remove it (#40085).Remove
WorkspaceFailureOutputPane- document load errors will appear in Error List.