Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ICodeGenerationService and CodeGenerationSymbolFactory public #43056

Closed
2 tasks
mavasani opened this issue Apr 3, 2020 · 2 comments
Closed
2 tasks

Make ICodeGenerationService and CodeGenerationSymbolFactory public #43056

mavasani opened this issue Apr 3, 2020 · 2 comments
Labels
Area-IDE Feature Request Resolution-By Design The behavior reported in the issue matches the current design
Milestone
Backlog

Comments

@mavasani
Copy link
Contributor

mavasani commented Apr 3, 2020 •
edited
Loading

https://github.com/dotnet/roslyn/blob/master/src/Workspaces/Core/Portable/CodeGeneration/ICodeGenerationService.cs

https://github.com/dotnet/roslyn/blob/master/src/Workspaces/Core/Portable/CodeGeneration/CodeGenerationSymbolFactory.cs

The API needs to be polished, similar to SyntaxGenerator, and exposed as a new type SymbolGenerator. We also need to remove the duplication between the APIs in SyntaxGenerator and CodeGenerationSymbolFactory that expose similar syntax generation APIs, but latter have more richer options to control the syntax generation.

CodeFixProviders that are blocked from being able to ported to CodeStyle layer due to this functionality:

  • MakeLocalFunctionStaticCodeFixProvider
  • CSharpUseLocalFunctionCodeFixProvider
@mavasani
Copy link
Contributor Author

mavasani commented Apr 3, 2020

@CyrusNajmabadi @sharwell

mavasani added a commit to mavasani/roslyn that referenced this issue Apr 3, 2020
@mavasani
Port MakeLocalFunctionStatic analyzer and tests to shared layer
d59a4cf 
CodeFix has not yet been ported because it depends on internal CodeGenerationSymbolFactory APIs. dotnet#43056 tracks making these APIs public and subsequently porting the fixer. To enable porting the tests, I have added a workaround in CodeStyle layer test framework to use the IDE code fixer with the CodeStyle layer analyzer for tests.
@mavasani mavasani mentioned this issue Apr 3, 2020
Closed
mavasani added a commit to mavasani/roslyn that referenced this issue Apr 8, 2020
@mavasani
Port CSharpUseLocalFunction analyzer/tests to shared layer
1045705 
Porting the code fix is blocked on dotnet#43056
@mavasani mavasani mentioned this issue Apr 8, 2020
Merged
@jinujoseph jinujoseph added this to the Backlog milestone Apr 8, 2020
@mavasani mavasani mentioned this issue Apr 4, 2022
Merged
@Youssef1313 Youssef1313 mentioned this issue Jul 21, 2022
Closed
@mavasani mavasani mentioned this issue Feb 11, 2023
Merged
@CyrusNajmabadi
Copy link
Member

Closing out. Both of these fixers were moved down to shared layer. We instead made these apis shareable.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
@CyrusNajmabadi CyrusNajmabadi added the Resolution-By Design The behavior reported in the issue matches the current design label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Feature Request Resolution-By Design The behavior reported in the issue matches the current design
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@CyrusNajmabadi @mavasani @jinujoseph