Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit tests are approaching the string limit #57226

Closed
RikkiGibson opened this issue Oct 19, 2021 · 2 comments · Fixed by #57238
Closed

Emit tests are approaching the string limit #57226

RikkiGibson opened this issue Oct 19, 2021 · 2 comments · Fixed by #57238
Assignees

Comments

@RikkiGibson
Copy link
Contributor

While bringing the features/param-nullchecking branch up to date, I found the following build error:

CSC : error CS8103: Combined length of user strings used by the program exceeds allowed limit. Try to decrease use of string literals. [C:\Users\rikki\src\roslyn\src\Compilers\CSharp\Test\Emit\Microsoft.CodeAnalysis.CSharp.Emit.UnitTests.csproj]

I think the 1400~ lines of emit tests in the feature branch pushed us over an edge. We probably need to factor another test project out of the current 'Emit' test project.

Any strategies/suggestions for how to do this split would be welcome. I will try soon to write up a script to count up the sizes of string constants in different source files. Maybe a logical split will become apparent then.

cc @dotnet/roslyn-compiler

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 19, 2021
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 19, 2021
@jaredpar
Copy link
Member

Any strategies/suggestions for how to do this split would be welcome. I will try soon to write up a script to count up the sizes of string constants in different source files. Maybe a logical split will become apparent then.

I think this is the best approach here and I'm hopeful a logical split becomes apparent.

Do we know what the limit is here that we're working against? I forget the exact size here.

@RikkiGibson RikkiGibson self-assigned this Oct 19, 2021
@RikkiGibson
Copy link
Contributor Author

For now will just introduce an 'Emit2' project which new tests can go into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants