Add Emit2 test project #57238
Add Emit2 test project #57238
Conversation
|
Can we link to the issue which inspired this and has the reasons for why we need yet another Emit test project here? |
There was a problem hiding this comment.
Please look through our scripts and add this test where appropriate (such as https://github.com/dotnet/roslyn/blob/main/eng/build.ps1#L333)
|
Did a search for |
|
Is there anything special we need to do to mark the test project as non-shipping? Or is the whole test folder automatically marked as such? |
It appears that some Arcade configuration sees that the project name ends with UnitTests and sets the 'IsUnitTestProject' property which sets the 'IsShipping=false' property. I verified in the binlog that 'IsShipping' is false for the new project. |
| @@ -337,6 +337,7 @@ function GetCompilerTestAssembliesIncludePaths() { | |||
| $assemblies += " --include '^Microsoft\.CodeAnalysis\.CSharp\.Symbol\.UnitTests$'" | |||
| $assemblies += " --include '^Microsoft\.CodeAnalysis\.CSharp\.Semantic\.UnitTests$'" | |||
| $assemblies += " --include '^Microsoft\.CodeAnalysis\.CSharp\.Emit\.UnitTests$'" | |||
| $assemblies += " --include '^Microsoft\.CodeAnalysis\.CSharp\.Emit2\.UnitTests$'" | |||
There was a problem hiding this comment.
Just curious, what does this list do (if you know)?
There was a problem hiding this comment.
Its the list of tests that are considered 'compiler' so you can run just the compiler tests without everything else.
There was a problem hiding this comment.
Which then controls what the IOperation hook is run on.
ghost
added this to the 
Closes #57226
See https://github.com/dotnet/roslyn/runs/3944469911 for proof that the tests run in CI :)
cc @dotnet/roslyn-compiler