Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restrict Peek Definition to showing only method signatures #61401

Closed
Varorbc opened this issue May 19, 2022 · 2 comments
Closed

Don't restrict Peek Definition to showing only method signatures #61401

Varorbc opened this issue May 19, 2022 · 2 comments
Labels
Area-IDE Navigation-SourceLink Metadata as Source, SourceLink, Decompilation Need Design Review The end user experience design needs to be reviewed and approved. Resolution-Duplicate The described behavior is tracked in another issue

Comments

@Varorbc
Copy link

Varorbc commented May 19, 2022 •
edited by davidwengier
Loading

Peek Definition is currently hard coded to show signatures only, so it will never show Source Link, Embedded or Decompiled source. This makes the experience not inline with, and worse than, Go to Definition.

Originally posted by @Varorbc in #61398 (comment)
Why is the effect of peek definition and go to definitions different?

image
image
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 19, 2022
@davidwengier davidwengier changed the title why is the effect of peek definition and go to definitions different? Don't restrict Peek Definition to showing only method signatures May 19, 2022
@davidwengier davidwengier added Navigation-SourceLink Metadata as Source, SourceLink, Decompilation Need Design Review The end user experience design needs to be reviewed and approved. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels May 19, 2022
@sharwell
Copy link
Member

Duplicate of #23480

@sharwell sharwell marked this as a duplicate of #23480 May 19, 2022
@sharwell sharwell closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2022
@sharwell sharwell added the Resolution-Duplicate The described behavior is tracked in another issue label May 19, 2022
@davidwengier
Copy link
Contributor

Thanks @sharwell!

Wish I'd known that existed before, I reckon I've made at least 3 or 4 separate commits to preserve the current behaviour, thinking it was desired.

@sharwell sharwell moved this to Need Update in IDE: Design review Aug 22, 2023
@CyrusNajmabadi CyrusNajmabadi moved this from Need Update to Complete in IDE: Design review Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Navigation-SourceLink Metadata as Source, SourceLink, Decompilation Need Design Review The end user experience design needs to be reviewed and approved. Resolution-Duplicate The described behavior is tracked in another issue
Projects
IDE: Design review
Status: Complete
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidwengier @sharwell @Varorbc