Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peek Definition does not work with decompiled sources #23480

Closed
sharwell opened this issue Nov 30, 2017 · 0 comments · Fixed by #61427
Closed

Peek Definition does not work with decompiled sources #23480

sharwell opened this issue Nov 30, 2017 · 0 comments · Fixed by #61427
Labels
Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
Backlog

Comments

@sharwell
Copy link
Member

From @jasonmalinowski in #23430 (comment):

Why false here? The expectation here is both behave the same. That might that this dialog should be pushed into the metadata as source file service, or maybe that gets a separate function GetGeneratedFileThatAsksIfYouWantToDecompileOrNotAsync()?

Peek Definition should be updated to support decompiled sources after the legal disclaimer workflow disruption is resolved with #23479.
@sharwell sharwell added Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it labels Nov 30, 2017
@sharwell sharwell added this to the 15.6 milestone Nov 30, 2017
@sharwell sharwell mentioned this issue Nov 30, 2017
Merged
@jcouv jcouv added the Area-IDE label Dec 10, 2017
@jinujoseph jinujoseph modified the milestones: 15.6, 15.8 Jan 8, 2018
@sharwell sharwell mentioned this issue Apr 3, 2018
Closed
@jinujoseph jinujoseph modified the milestones: 15.8, Unknown May 29, 2018
@jinujoseph jinujoseph mentioned this issue Mar 2, 2021
Closed
@sharwell sharwell mentioned this issue May 19, 2022
Closed
@davidwengier davidwengier mentioned this issue May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Allow source link, embedded or decompiled source in Peek Definition davidwengier/roslyn
3 participants
@sharwell @jinujoseph @jcouv