Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider consolidating CA1801 and IDE0060 #63641

Closed
Youssef1313 opened this issue Aug 28, 2022 · 1 comment
Closed

Consider consolidating CA1801 and IDE0060 #63641

Youssef1313 opened this issue Aug 28, 2022 · 1 comment
Assignees
@mavasani
Labels
Area-IDE
Milestone
17.4

Comments

@Youssef1313
Copy link
Member

Both analyzers are for unused parameters. I think it makes sense to either deprecate CA1801 or IDE0060, and make sure to port unit tests for the deprecated analyzer to the other to make sure everything is handled correctly.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 28, 2022
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 29, 2022
@arunchndr arunchndr added this to the 17.4 milestone Aug 29, 2022
@mavasani
Copy link
Contributor

@Youssef1313 This was already done by @Evangelink a while back: dotnet/roslyn-analyzers#4535. He also graciously added documentation for the same: dotnet/docs#21882. I am going to close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-IDE
Projects
None yet
Milestone
17.4
Development

No branches or pull requests
3 participants
@mavasani @Youssef1313 @arunchndr