Deprecate CA1801 in favor of IDE0060 #21882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Dec 8, 2020
| @@ -45,6 +45,10 @@ This rule does not examine the following kinds of methods: | |||
|
|
|||
| This rule does not flag parameters that are named with the [discard](../../../csharp/discards.md) symbol, for example, `_`, `_1`, and `_2`. This reduces warning noise on parameters that are needed for signature requirements, for example, a method used as a delegate, a parameter with special attributes, or a parameter whose value is implicitly accessed at run time by a framework but is not referenced in code. | |||
|
|
|||
| > [!NOTE] | |||
| > This rule has been deprecated in favor of [IDE0060](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060). You can enforce this analyzer by following [this guide](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/overview#code-style-analysis). | |||
| > For more information, see [Deprecated rules](https://docs.microsoft.com/visualstudio/code-quality/fxcop-unported-deprecated-rules). | |||
There was a problem hiding this comment.
- Do we need a parallel PR to MicrosoftDocs/visualstudio-docs page?
- The linked page says deprecated rules for FxCop, which was deleted recently, so the change only affects NetAnalyzers package. Do the linked page needs to be updated regarding this?
There was a problem hiding this comment.
I'd just suggest leaving this part out for now (for more info, see deprecated rules).
There was a problem hiding this comment.
Also, those deprecated rules refer to FxCop rules that were never ported as an analyzer. CA1801 was ported, so I don't think it belongs in that list.
Youssef1313
reviewed
Dec 8, 2020
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
gewarren
reviewed
Dec 8, 2020
| @@ -45,6 +45,10 @@ This rule does not examine the following kinds of methods: | |||
|
|
|||
| This rule does not flag parameters that are named with the [discard](../../../csharp/discards.md) symbol, for example, `_`, `_1`, and `_2`. This reduces warning noise on parameters that are needed for signature requirements, for example, a method used as a delegate, a parameter with special attributes, or a parameter whose value is implicitly accessed at run time by a framework but is not referenced in code. | |||
|
|
|||
| > [!NOTE] | |||
| > This rule has been deprecated in favor of [IDE0060](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0060). You can enforce this analyzer by following [this guide](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/overview#code-style-analysis). | |||
| > For more information, see [Deprecated rules](https://docs.microsoft.com/visualstudio/code-quality/fxcop-unported-deprecated-rules). | |||
There was a problem hiding this comment.
I'd just suggest leaving this part out for now (for more info, see deprecated rules).
Evangelink
commented
Dec 8, 2020
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
approved these changes
Dec 8, 2020
|
@Evangelink Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecate CA1801 in favor of IDE0060.
Relates to dotnet/roslyn-analyzers#4498