Stack overflow in Rosyln CodeAnalysis when ambiguous name is used

[MoFtZ]

Version Used:

.NET 8.0 (SDK 8.0.100, Windows x64 Installer)

Steps to Reproduce:

1. Create a net8.0 project.
2. Create a C# file (Context.cs) containing a class having a Property and ReturnType with the same/ambiguous name.

namespace ILGPU
{
    public class Context
    {
        // RuntimeSystem is the name of a Property in the Context class.
        // RuntimeSystem is also the name of a Class.
        public const string RuntimeAssemblyName = RuntimeSystem.AssemblyName;
        public RuntimeSystem RuntimeSystem { get; }
    }
}

3. Create a C# file (AssemblyAttributes.cs) that indirectly references this ambiguous name.

using ILGPU;
using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo(Context.RuntimeAssemblyName)]

4. Run the command dotnet build.

I have attached code that reproduces the issue, following the above steps.
MinimalRepro.zip

Diagnostic Id:

Running dotnet build generates a stack overflow in Roslyn.

Command line output:

C:\MinimalRepro>dotnet build
MSBuild version 17.8.3+195e7f5a3 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
C:\Program Files\dotnet\sdk\8.0.100\Roslyn\Microsoft.CSharp.Core.targets(84,5): error : Stack overflow. [C:\MinimalRepro\ILGPU.csproj::TargetFramework=net8.0]
C:\Program Files\dotnet\sdk\8.0.100\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.Binder.<BindNamespaceOrTypeOrAliasSymbol>g__bindAlias|1004_3(<>c__DisplayClass1004_0 ByRef) [C:\MinimalRepro\ILGPU.csproj::TargetFramework=net8.0]
C:\Program Files\dotnet\sdk\8.0.100\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.Binder.BindNamespaceOrTypeOrAliasSymbol(Microsoft.CodeAnalysis.CSharp.Syntax.ExpressionSyntax, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag, Roslyn.Utilities.ConsList`1<Microsoft.CodeAnalysis.CSharp.Symbols.TypeSymbol>, Boolean) [C:\MinimalRepro\ILGPU.csproj::TargetFramework=net8.0]
C:\Program Files\dotnet\sdk\8.0.100\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.Binder.BindNamespaceOrTypeSymbol(Microsoft.CodeAnalysis.CSharp.Syntax.ExpressionSyntax, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag, Roslyn.Utilities.ConsList`1<Microsoft.CodeAnalysis.CSharp.Symbols.TypeSymbol>, Boolean) [C:\MinimalRepro\ILGPU.csproj::TargetFramework=net8.0]
C:\Program Files\dotnet\sdk\8.0.100\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.Binder.BindQualifiedName(Microsoft.CodeAnalysis.CSharp.Syntax.ExpressionSyntax, Microsoft.CodeAnalysis.CSharp.Syntax.SimpleNameSyntax, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag, Roslyn.Utilities.ConsList`1<Microsoft.CodeAnalysis.CSharp.Symbols.TypeSymbol>, Boolean) [C:\MinimalRepro\ILGPU.csproj::TargetFramework=net8.0]
C:\Program Files\dotnet\sdk\8.0.100\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.Binder.BindNamespaceOrTypeOrAliasSymbol(Microsoft.CodeAnalysis.CSharp.Syntax.ExpressionSyntax, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag, Roslyn.Utilities.ConsList`1<Microsoft.CodeAnalysis.CSharp.Symbols.TypeSymbol>, Boolean) [C:\MinimalRepro\ILGPU.csproj::TargetFramework=net8.0]
C:\Program Files\dotnet\sdk\8.0.100\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.Binder.BindNamespaceOrTypeSymbol(Microsoft.CodeAnalysis.CSharp.Syntax.ExpressionSyntax, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag, Roslyn.Utilities.ConsList`1<Microsoft.CodeAnalysis.CSharp.Symbols.TypeSymbol>, Boolean) [C:\MinimalRepro\ILGPU.csproj::TargetFramework=net8.0]
C:\Program Files\dotnet\sdk\8.0.100\Roslyn\Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.Binder.BindQualifiedName(Microsoft.CodeAnalysis.CSharp.Syntax.ExpressionSyntax, Microsoft.CodeAnalysis.CSharp.Syntax.SimpleNameSyntax, Microsoft.CodeAnalysis.CSharp.BindingDiagnosticBag, Roslyn.Utilities.ConsList`1<Microsoft.CodeAnalysis.CSharp.Symbols.TypeSymbol>, Boolean) [C:\MinimalRepro\ILGPU.csproj::TargetFramework=net8.0]
<snip>

Repeats "BindNamespaceOrTypeOrAliasSymbol, BindNamespaceOrTypeSymbol, BindQualifiedName".

Expected Behavior:

Expecting net8.0 to compile the existing code without any issues.

This is a regression, as the use of RuntimeSystem as both a property name and class name was not an issue on previous compilers (net48, net6.0, net7.0, etc).

Actual Behavior:

We are trying to enable support for .NET 8 for our existing .NET class library.

In net8.0, Roslyn is getting confused with RuntimeSystem. and generating a Stack overflow at compile-time.

Known workarounds:

1. Change [assembly: InternalsVisibleTo(Context.RuntimeAssemblyName)] to `[assembly: InternalsVisibleTo("ILGPU")]
2. Removing public RuntimeSystem RuntimeSystem { get; }
3. Renaming the RuntimeSystem property.

[333fred]

@MoFtZ just to make sure, you're not expecting the minimal repo version you submitted there to compile, right? Only a more complete example with various other types? Because your zip does not compile on .NET 7, so I'm just making sure.

[MoFtZ]

hi @333fred, yes, that is correct. You should get compiler errors for the missing RuntimeSystem class.