Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented out class #10

Merged
merged 1 commit into from
Feb 17, 2015
Merged

Remove commented out class #10

merged 1 commit into from
Feb 17, 2015

Conversation

stefansedich
Copy link
Contributor

Just a bit of clean-up!

@theoy theoy added this to the Unknown milestone Jan 16, 2015
@theoy
Copy link
Contributor

theoy commented Jan 20, 2015

@VSadov - any context on why this is commented instead of deleted?

@VSadov
Copy link
Member

VSadov commented Jan 20, 2015

At some point we had internal visitors generic visitors parameterized on parameters like SyntaxVisitor<TArgument, TResult> .They were convenient, but not very fast because of virtual generic Accept. Eventually all the visitors switched to the faster version SyntaxVisitor<TResult>.
There were some arguments that at some point we might still need the convenience of SyntaxVisitor<TArgument, TResult>, so it was not removed, just commented out.

Perhaps it is time to remove it :-)

@VSadov
Copy link
Member

VSadov commented Jan 20, 2015

.

@srivatsn
Copy link
Contributor

@stefansedich If you haven't already, can you please sign the CLA here - https://cla2.dotnetfoundation.org ?

@dnfclas
Copy link

dnfclas commented Feb 16, 2015

@stefansedich, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@stefansedich
Copy link
Contributor Author

All done @srivatsn

srivatsn added a commit that referenced this pull request Feb 17, 2015
@srivatsn srivatsn merged commit 1922539 into dotnet:master Feb 17, 2015
@srivatsn
Copy link
Contributor

Great thanks.

@jaredpar jaredpar removed this from the Unknown milestone Nov 23, 2015
@davkean davkean added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Ready Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants