Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InteractiveWindow #13143

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Remove InteractiveWindow #13143

merged 1 commit into from
Oct 7, 2016

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 13, 2016 •
edited
Loading

@tmat tmat added the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Aug 13, 2016
@tmat tmat force-pushed the RemoveIW branch 2 times, most recently from c2874a2 to 67cd637 Compare August 20, 2016 01:30
@tmat
Copy link
Member Author

tmat commented Aug 20, 2016

ETA test failures expected.

@tmat tmat removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Aug 20, 2016
@tmat
Copy link
Member Author

tmat commented Aug 20, 2016

@dotnet/roslyn-infrastructure @jasonmalinowski @shyamnamboodiripad @brettfo @jmarolf Please review, especially VSIX related changes.

@tmat
Copy link
Member Author

tmat commented Aug 20, 2016

@KevinH-MS

@tmat tmat force-pushed the RemoveIW branch 3 times, most recently from fdba7ac to 90103c0 Compare August 24, 2016 01:39
@tmat tmat mentioned this pull request Sep 8, 2016
Closed
@tmat tmat force-pushed the RemoveIW branch 2 times, most recently from 0b21c96 to d54df11 Compare October 7, 2016 20:16
@tmat
Copy link
Member Author

tmat commented Oct 7, 2016

@jasonmalinowski @dotnet/roslyn-infrastructure

@tmat
Copy link
Member Author

tmat commented Oct 7, 2016

@KevinH-MS

KevinH-MS
KevinH-MS reviewed Oct 7, 2016
View reviewed changes
src/EditorFeatures/CSharpTest/project.json
"RoslynDependencies.Microsoft.VisualStudio.Text.Internal": {
"version": "14.3.25407",
"suppressParent": "all"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be. Build fails otherwise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising, but I accept that there are mysteries in the universe... 😄

Perhaps we were embedding the interop types in the InteractiveWindow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the InteractiveWindow uses some types from this, so it doesn't surprise me.

KevinH-MS
KevinH-MS reviewed Oct 7, 2016
View reviewed changes
src/VisualStudio/InteractiveServices/project.json
@@ -2,7 +2,8 @@
"dependencies": {
"RoslynDependencies.Microsoft.VisualStudio.ComponentModelHost": "14.3.25407",
"Microsoft.VisualStudio.Editor": "14.3.25407",
"Microsoft.VisualStudio.Shell.14.0": "14.3.25407"
"Microsoft.VisualStudio.Shell.14.0": "14.3.25407",
"Microsoft.VisualStudio.VsInteractiveWindow": "2.0.0-beta5-60820-04"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like indent is off

@KevinH-MS
Copy link
Contributor

:shipit:

@tmat tmat merged commit db7a842 into dotnet:master Oct 7, 2016
jasonmalinowski
jasonmalinowski reviewed Oct 8, 2016
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/Deployment/source.extension.vsixmanifest
@@ -29,15 +29,6 @@
Location="|VisualStudioSetup;VSIXContainerProjectOutputGroup|"
Id="|VisualStudioSetup;VSIXIdentifierProjectOutputGroup|" />

<Dependency d:ProjectName="VisualStudioInteractiveWindow"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this dependency (in some modified form, obviously) have been left?

src/EditorFeatures/CSharpTest/project.json
"RoslynDependencies.Microsoft.VisualStudio.Text.Internal": {
"version": "14.3.25407",
"suppressParent": "all"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the InteractiveWindow uses some types from this, so it doesn't surprise me.

@tmat tmat deleted the RemoveIW branch August 16, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinH-MS KevinH-MS KevinH-MS left review comments

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

Assignees
No one assigned
Labels
Area-Interactive cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmat @KevinH-MS @jasonmalinowski @Pilchie @dnfclas