Don't show builder after dot #15564
Merged
Don't show builder after dot #15564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
approved these changes
Nov 28, 2016
| // In the following situation, the type inferrer will infer Task to support target type preselection | ||
| // Action a = Task.$$ | ||
| // We need to explicitly exclude invocation/member access from suggestion mode | ||
| var previousToken = token.GetPreviousTokenIfTouchingWord(position); |
There was a problem hiding this comment.
I'd much rather have the syntax check up front. Asking if we're in a locatoin where you could have an inferred lambda.
There was a problem hiding this comment.
Done, thanks. This actually looks way better.
|
Fixes #15443 |
|
retest windows_debug_unit32_prtest please |
| // We need to explicitly exclude invocation/member access from suggestion mode | ||
| var previousToken = token.GetPreviousTokenIfTouchingWord(position); | ||
| if (previousToken.IsKind(SyntaxKind.DotToken) && | ||
| previousToken.Parent.IsKind(SyntaxKind.InvocationExpression, SyntaxKind.SimpleMemberAccessExpression)) |
There was a problem hiding this comment.
dot token can't be parented by an invocation expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag @dotnet/roslyn-ide for review