Ensure that cref completion uses Speculative SemanticModel. Fixes TFS #9... #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any way to test this? |
|
I couldn't think of a good way. We could have a test that runs the providers against an ISemanticInfoService that asserts it isn't called on doc comments, I suppose. |
added 2 commits
May 1, 2015 13:51
rchande
force-pushed
the
CrefCompletionPerf
branch
from
267fb1d to
3f6ac72
Compare
|
@Pilchie I added some tests. |
|
Thanks, LGTM |
|
test this please |
|
👍 |
rchande
pushed a commit
that referenced
this pull request
May 4, 2015
Ensure that cref completion uses Speculative SemanticModel. Fixes TFS #9...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TFS #988380
Potential reviewers: @balajikris @basoundr @davkean @dpoeschl @jasonmalinowski @jmarolf @Pilchie