Remove Portable server #25449
Merged
Remove Portable server #25449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jaredpar This doesn't touch any shipping code and is not expected to result in any product changes, so I don't believe it needs ask mode approval. |
This code was built as a prototype for porting the compiler server to other platforms. It has now been ported to CoreCLR and multiple OSes through multitargeting. The portable server cannot meet our security requirements and will never ship, so it's continued existence in our code is merely confusing to anyone who happens upon it.
agocke
force-pushed
the
remove-portable-compilerserver
branch
from
51ca863 to
d6704d5
Compare
jaredpar
approved these changes
Mar 13, 2018
|
@agocke I just refreshed the tuple-equality branch with latest dev15.7.x bits and I'm getting a build error that seems related to this change. Any ideas? |
|
Fixed it locally with following change. No idea why this would not be blocked in CI. diff --git a/src/Compilers/CSharp/Portable/CSharpCodeAnalysis.csproj b/src/Compilers/CSharp/Portable/CSharpCodeAnalysis.csproj
index adfd6c5..e71c150 100644
--- a/src/Compilers/CSharp/Portable/CSharpCodeAnalysis.csproj
+++ b/src/Compilers/CSharp/Portable/CSharpCodeAnalysis.csproj
@@ -66,6 +66,7 @@
<InternalsVisibleTo Include="Microsoft.CodeAnalysis.CompilerServer" />
<InternalsVisibleTo Include="VBCSCompiler" />
<InternalsVisibleTo Include="VBCSCompilerPortable" />
+ <InternalsVisibleToTest Include="VBCSCompilerTests" />
<InternalsVisibleToTest Include="Roslyn.Compilers.UnitTests" />
<InternalsVisibleToTest Include="Roslyn.Compilers.CompilerServer.UnitTests" />
<InternalsVisibleToTest Include="Roslyn.Compilers.CSharp.CommandLine.UnitTests" /> |
|
Never mind, I reverted the "fix" and things are building fine. I must have messed something up locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was built as a prototype for porting the compiler server to
other platforms. VBCSCompiler has now been ported to CoreCLR and multiple OSes
through multitargeting. The portable server cannot meet our security
requirements and will never ship, so it's continued existence in our
code is merely confusing to anyone who happens upon it.