Add support for VSMac unit test synchronization context #27475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This synchronization context is used by MD's test suite - it is based on the idea that the IDE is not yet initialized so headless tests can run, so it just routes the main synchronization context calls into the native OS' main thread implementation
sharwell
approved these changes
Jun 5, 2018
jasonmalinowski
approved these changes
Jun 5, 2018
jinujoseph
added
Area-IDE
Community
|
Test only change, so M2 approval not needed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask Mode template not completed
Customer scenario
Customer not affected.
Bugs this fixes
Workarounds, if any
A lot of refactoring in VSMac test suites to get this done. This is a workaround to move us forward until we properly layer the integration test suites.
Risk
Just adds new enum values that allow Xwt-based synchronization context to function with default data.
Performance impact
None
Is this a regression from a previous update?
No
Root cause analysis
We weren't hitting into ForegroundThreadData needed to be initialized in parts of VSMac test suite
How was the bug found?
Test documentation updated?
None needed.