Stop NGENing System.Net.Http and dependencies #27537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you retarget to dev15.8.x-preview3-vs-deps for the insertion? |
| @@ -41,15 +41,15 @@ folder InstallDir:\MSBuild\15.0\Bin\Roslyn | |||
| file source=$(OutputPath)\Vsix\CompilerExtension\Microsoft.Win32.Primitives.dll vs.file.ngenArchitecture=all | |||
| file source=$(OutputPath)\Vsix\CompilerExtension\System.AppContext.dll vs.file.ngenArchitecture=all | |||
| file source=$(OutputPath)\Vsix\CompilerExtension\System.Console.dll vs.file.ngenArchitecture=all | |||
| file source=$(OutputPath)\Vsix\CompilerExtension\System.Diagnostics.DiagnosticSource.dll vs.file.ngenArchitecture=all | |||
| file source=$(OutputPath)\Vsix\CompilerExtension\System.Diagnostics.DiagnosticSource.dll | |||
There was a problem hiding this comment.
We should really put comments here why these are different.
There was a problem hiding this comment.
Is there a way to explicitly opt out of NGEN vs. implicitly doing so?
jasonmalinowski
approved these changes
Jun 6, 2018
tannergooding
approved these changes
Jun 6, 2018
|
Related dotnet/sdk#2227 |
jaredpar
approved these changes
Jun 6, 2018
|
There is a build boss error: Investigating why. |
|
Why do we still include them if we know we're not gonna use them? |
|
@tmat see dotnet/sdk#2227 This is what the SDK believes we are using. Previously we tried to be smart and exclude items we thought we weren't using. That lead to a series of different issues. There just doesn't appear to be a way to win here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is failing NGEN in official builds, as binding redirects to dependencies are not generated correctly.
We don't actually use/load that assembly in any way, so let's stop NGENing it.
cc @jaredpar @tannergooding @jasonmalinowski