Add code fixer to add [Obsolete] attribute on code that gets an 'obsolete' warning.

[CyrusNajmabadi]

Fixes one of the cases reported here: #27168

Very simple feature. When it hears about "you're using something obsolete" from teh compiler, offers to add the 'obsolete' attribute itself to your code. Useful when doing something like overriding an obsolete member with something non-obsolete:

[CyrusNajmabadi]

Tagging @dotnet/roslyn-ide @jcouv . Tests incoming.

[CyrusNajmabadi]

@sharwell Do you have any other concerns?
@dotnet/roslyn-ide can i get eyes on this?

[CyrusNajmabadi]

@sharwell Do you have any other concerns?
@dotnet/roslyn-ide can i get eyes on this?

Have the design concerns been discussed?

[sharwell]

@CyrusNajmabadi If the two remaining warnings I pointed out before (CS1062, CS1064 for collection initializers) can be implemented without a problem, it would be nice to have the complete feature done. Otherwise the primary code fix design here is approved. If there is a reason why it would be problematic to implement the last two cases, please let us know.

[CyrusNajmabadi]

@CyrusNajmabadi If the two remaining warnings I pointed out before (CS1062, CS1064 for collection initializers) can be implemented without a problem, it would be nice to have the complete feature done. Otherwise the primary code fix design here is approved. If there is a reason why it would be problematic to implement the last two cases, please let us know.

Should be no problem. Will do tonight/tomorrow.

[sharwell]

This needs tests, but the implementation is looking complete. @CyrusNajmabadi if you won't be able to get the tests let me know and I'll try to find some time to add them to the branch you started.

[CyrusNajmabadi]

@jaredpar @jasonmalinowski something is causing the CI system to cancel testing PRs:

[CyrusNajmabadi]

@sharwell this is ready to go in. Can you look?

[jaredpar]

something is causing the CI system to cancel testing PRs

Are you referring to the behavior that when you push it cancels the PR builds that are in progress? If so I've already given the AzDev team the feedback that this behavior needs to be configurable. I specifically sent them some of our PRs as examples of how our users take advantage of the testing happening on every push. Fixing this is in the works but don't expect it anytime soonish.

[CyrusNajmabadi]

Are you referring to the behavior that when you push it cancels the PR builds that are in progress?

Wat... is that what's happening? What sort of crazy CI behavior is that? :-/

If so I've already given the AzDev team the feedback that this behavior needs to be configurable. I specifically sent them some of our PRs as examples of how our users take advantage of the testing happening on every push. Fixing this is in the works but don't expect it anytime soonish.

Ok, great. Thanks for sending that message along. Let them know that a CI/CD system that doesn't actually do the 'C' part is really lacking :)

[CyrusNajmabadi]

@jaredpar Feel free to point the devops team at their own messaging of the product: https://docs.microsoft.com/en-us/azure/devops/learn/what-is-continuous-integration

Continuous Integration (CI) is the process of automating the build and testing of code every time a team member commits changes to version control.

[sharwell]

This is still missing tests for the following:

• Cases where error: true is used (it would be good to create this test as a theory so it's easy to verify that the fix is offered if and only if error: false is used)
• Obsolete collection initializer warnings

[CyrusNajmabadi]

@sharwell

Cases where error: true is used

Tests added.

Obsolete collection initializer warnings

These tests are here already.

Thanks!

[sharwell]

@jinujoseph for approval

[CyrusNajmabadi]

@jinujoseph this can go in. thanks!

[CyrusNajmabadi]

Thanks!