Remove tail recursion and enable cancellation #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More reviewers: @DustinCampbell, @balajikris, @dpoeschl@, @brettfo |
|
👍 |
|
retest this please |
|
retest this please |
|
👍 |
| // reached end of tree | ||
| return default(SyntaxToken); | ||
| } | ||
| // recursively find the end token outside of inseparable regions |
There was a problem hiding this comment.
Remove the word "recursively"?
|
👍 |
|
Approved 6/3 by ML Shiproom. |
mattwar
added a commit
that referenced
this pull request
Jun 3, 2015
Remove tail recursion and enable cancellation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes devdiv 1089540
The problem was a stack overflow in the formatter when pasting a file with a enormous array initializer. The culprit was a method
FormattingContext.GetEndTokenForRelativeIndentationSpanthat was making a recursive call after looking forward to the next token, attempting to find the end token for a relative indentation operation. Fortunately it was simply tail recursive and was easy to rewrite as a loop.Also noticed that the whole operation when successful was taking tremendous amount of time (on order of 10 minutes), and was stuck in this recursive method for a long time without ability to cancel, so I plumbed cancellation through to its loop.
Also noticed that the dialog that pops up on slow execution of formatting did not have a cancel button, so I enabled that too.
@heejaechang @jasonmalinowski @Pilchie please review.