Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion does not work in the Immediate Window after expression evaluation #33875

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

@ivanbasov ivanbasov added this to the 16.0.P4 milestone Mar 5, 2019
@ivanbasov ivanbasov requested review from jasonmalinowski and a team March 5, 2019 21:57
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanbasov Did we also want to do the cleanup of:

  1. Instead of having RemoveContext() call Dispose(), have it have the full logic for cleaning up and disposing (i.e. just inline the Dispose() contents)
  2. Dispose() can call RemoveContext() of course to remove anything that's left, but then that's an explicit case.

As @AmadeusW observed, Dispose() is really intended to be "final", and it's odd that we're using that as a random helper in a most-definitely-not final action.

@ivanbasov
Copy link
Contributor Author

Thank you, @jasonmalinowski ! I have swapped Dispose and RemoveContext in DebuggerIntelliSenseFilter. However, AbstractDebuggerIntelliSenseContext.Dispose still has a wide scope. I'm not sure we we should introduce one more method here and put everything from Dispose there.

@ivanbasov ivanbasov merged commit 7d31dd6 into dotnet:dev16.0-vs-deps Mar 6, 2019
@ivanbasov ivanbasov deleted the immediate branch March 6, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge Area-IDE Bug IDE-IntelliSense Completion, Signature Help, Quick Info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants