Remove IFromIndexOperation completely #34306
Conversation
| /// <summary> | ||
| /// Represents the C# '^' operator. | ||
| /// </summary> | ||
| Hat = 0x7, |
There was a problem hiding this comment.
Hat [](start = 8, length = 3)
Is this how it will be called in the language spec? #Closed
There was a problem hiding this comment.
| Microsoft.CodeAnalysis.CSharp.LanguageVersion.LatestMajor = 2147483645 -> Microsoft.CodeAnalysis.CSharp.LanguageVersion | ||
| Microsoft.CodeAnalysis.CSharp.LanguageVersion.Preview = 2147483646 -> Microsoft.CodeAnalysis.CSharp.LanguageVersion |
There was a problem hiding this comment.
Are there meaningful changes in this file? Please revert changes that simply move lines around
There was a problem hiding this comment.
Every change to the PublicAPI files is supposed to be followed by a call to sort-unshipped.cmd. That's all I did here.
There was a problem hiding this comment.
Would you prefer I change that in a separate PR? Or as separate commit to make reviewing easier?
There was a problem hiding this comment.
Every change to the PublicAPI files is supposed to be followed by a call to sort-unshipped.cmd.
This is the first time I hear about that. I see very little benefit and a lot of negatives in doing this. People should be able to examine the diff and quickly see what has changed, not just in PRs, but in history as well. Merge tools should be able to merge non-conflicting API changes automatically.
Would you prefer I change that in a separate PR? Or as separate commit to make reviewing easier?
I prefer that sorting was not done in this PR, or any other PR.
In reply to: 267972689 [](ancestors = 267972689)
There was a problem hiding this comment.
Sorting is extremely helpful for resolving conflicts in merge PRs, as changes to the public API are extremely likely to be added in the same section without sorting.
There was a problem hiding this comment.
Sorting is extremely helpful for resolving conflicts in merge PRs, as changes to the public API are extremely likely to be added in the same section without sorting.
I have an opposite experience. Also, when one merges additions from different branches he should be able to take both sides and move on, without having to run some other tools to sort, etc.
In reply to: 268290574 [](ancestors = 268290574)
| @@ -1,4 +1,3 @@ | |||
| Microsoft.CodeAnalysis.Editing.DeclarationModifiers.WithIsRef(bool isRef) -> Microsoft.CodeAnalysis.Editing.DeclarationModifiers | |||
There was a problem hiding this comment.
Please revert this change.
|
Done with review pass (iteration 2) #Closed |
agocke
force-pushed
the
remove-ifromendindex-ioperation
branch
from
2f33ee7 to
116b5f9
Compare
agocke
force-pushed
the
remove-ifromendindex-ioperation
branch
from
116b5f9 to
b42383a
Compare
|
@AlekseyTs I've removed the formatting change and just left the required changes. |
We previously decided to remove IFromIndexOperation in favor of using an IUnaryOperation to represent the
^syntax in C#, but did not have time to remove the interface completely. This PR finishes the change.