Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make compilation outputs available via a workspace service (#34809)" #35642

Merged
merged 1 commit into from
May 10, 2019
Merged

Revert "Make compilation outputs available via a workspace service (#34809)" #35642

merged 1 commit into from
May 10, 2019
+138 −1,113

Conversation

dpoeschl
Copy link
Contributor

@dpoeschl dpoeschl commented May 10, 2019 •
edited
Loading

This reverts commit 3bdbd56.

The original PR caused failures in VS tests which are preventing us from making insertions, so we're rolling back for now.

@dpoeschl dpoeschl requested review from a team as code owners May 10, 2019 20:50
@dpoeschl
Copy link
Contributor Author

Tag for approval @jasonmalinowski @tmat

jasonmalinowski
jasonmalinowski approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off in that this appears to be a revert of Tomas's changes into master. I have not reviewed the exact diff so if it was anything but a straight 'git revert' then this may require extra looking.

@dpoeschl dpoeschl merged commit cb056d8 into dotnet:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpoeschl @jasonmalinowski