Make compilation outputs available via a workspace service #35659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonmalinowski PTAL at the second commit |
jasonmalinowski
approved these changes
May 13, 2019
| @@ -259,6 +259,15 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim | |||
|
|
|||
| outputs = CType(environment.Workspace.GetCompilationOutputs(project.Test_VisualStudioProject.Id), CompilationOutputFilesWithImplicitPdbPath) | |||
| Assert.Equal("C:\NewFolder3\test3.dll", outputs.AssemblyFilePath) | |||
|
|
|||
| ' Relative path - set by VBIntelliProj in VB Web App project | |||
There was a problem hiding this comment.
Worth doing as a separate test method since this one is a bit special?
There was a problem hiding this comment.
I need it to test that the previously set value is cleared (Nothing), so it's convenient to have it after the previous cases.
|
Mock insertion PR build succeeded with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion on #34698. Instead of exposing paths/Streams on a project this change adds a workspace service that provides data from compiler output files.
The abstraction allows for the files to be in-memory or on a different machine. In the latter case it makes it possible to only transfer relevant parts of the output files rather then their entirety.
Fixes #34371