Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ReadOnlySpan initialization from static data (#24621) #37952

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Test ReadOnlySpan initialization from static data (#24621) #37952

merged 1 commit into from
Aug 14, 2019

Conversation

MykolaBalakin
Copy link
Contributor

Follow-up to #33088

@MykolaBalakin MykolaBalakin requested a review from a team as a code owner August 13, 2019 15:18
@jcouv jcouv added Area-Compilers Test Test failures in roslyn-CI Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Aug 13, 2019
@jcouv jcouv self-assigned this Aug 13, 2019
@jcouv jcouv added this to the 16.4 milestone Aug 13, 2019
jcouv
jcouv reviewed Aug 13, 2019
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv merged commit cadf31a into dotnet:master Aug 14, 2019
@jcouv
Copy link
Member

jcouv commented Aug 14, 2019

Merged. Thanks!

@jcouv jcouv modified the milestones: 16.4, 16.4.P1 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv left review comments

@333fred 333fred 333fred approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Test Test failures in roslyn-CI
Projects
None yet
Milestone
16.4.P1
Development

Successfully merging this pull request may close these issues.
3 participants
@MykolaBalakin @jcouv @333fred