Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to master-vs-deps #39963

Merged
22 commits merged into from
Nov 22, 2019
Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into master-vs-deps.

git fetch --all
git checkout merges/master-to-master-vs-deps
git reset --hard upstream/master-vs-deps
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-master-vs-deps --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

genlu and others added 21 commits November 12, 2019 16:59
…project's references, which improves perf by avoiding mapping assemblies to project.

Before:
compilation -> referenced assembly symbols -> metadata references |-> projects
                                                                                                              |-> PE references
now:
compilation |-> referenced projects -> assembly symbols -> corresponding metadata references
                    |-> referenced PE references -> assembly symbols
Improvement for completion of unimported types
Update the Spanish CI build to skip analyzers
Skip analyzers in all CI builds except correctness
…ak for TS and F#

Recent PR #39699 introduced a breaking API and functionality change for TypeScript and F# as they are using our internal option ClosedFileDiagnostics for controlling their full solution analysis experience. This PR restores the ClosedFileDiagnostics option and functionality for non C#/VB languages. Additionally, the newly added option SolutionCrawlerOptions.BackgroundAnalysisScope has been made a per-language option so that all languages can have different UI/setting for this option.
Re-add ServiceFeatureOnOffOptions.ClosedFileDiagnostic to fix the bre…
Update FormattingDiagnosticIds.cs
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 0cd8431 into master-vs-deps Nov 22, 2019
@ghost ghost deleted the merges/master-to-master-vs-deps branch November 22, 2019 17:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants