Add shared resx files to our shared projects #41775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from dotnet#41363 Third follow-up item from dotnet#41462 Apart from adding resx files, changes also include: 1. Moving resource strings duplicated across Workspaces and CodeStyle layer into the shared resx files 2. Source file changes to use the resource strings from the shared resx. We should no longer require use of `#if CODE_STYLE` in the shared layer for the purpose of resource strings.
|
NOTE: 208 out of the 250 changed files are xlf files. Strongly recommend reviewing with xlf files filtered: Review Link This is an extremely mechanical change with absolutely no semantic changes. |
Fantastic!!
This is very appreciated. Thanks for taking the time to do that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #41363
Third follow-up item from #41462
Apart from adding resx files, changes also include:
We should no longer require use of
#if CODE_STYLEin the shared layer for the purpose of resource strings.