Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to test plans for records and patterns #42033

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Feb 29, 2020

No description provided.

@jcouv jcouv self-assigned this Feb 29, 2020
@jcouv
Copy link
Member Author

jcouv commented Feb 29, 2020

Tagging @gafter @agocke for review (doc only)

@gafter
Copy link
Member

gafter commented Feb 29, 2020

It feels strange for "progress" to link to the test plan. The state of the pattern-matching implementation is tracked at #41502, not #40727 .

@jcouv
Copy link
Member Author

jcouv commented Feb 29, 2020

@gafter Previously we didn't have two issues tracking feature work. What's the intended difference between the implementation issue and the test plan? Could we merge them?

@gafter
Copy link
Member

gafter commented Feb 29, 2020

The test plan tracks test work. The implementation tracks compiler work. Both are needed. Tracking the former is the responsibility of the co-developers. Tracking the latter is the responsibility of the developer.

@gafter
Copy link
Member

gafter commented Mar 2, 2020

The outstanding work issue for pattern-matching is sort of the equivalent of #17952 for default implementation methods.

@jcouv
Copy link
Member Author

jcouv commented Mar 2, 2020

Updated to have both links

Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcouv jcouv merged commit 033e2cd into master Mar 2, 2020
@jcouv jcouv deleted the dev/jcouv/update-status-2 branch March 2, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants