Fix Issue #41822 Add IsNullOrEmpty or IsNullOrWhiteSpace check for method parameters throws an empty "message" #42101

Sliptory · 2020-03-02T20:41:43Z

#41822

...atures/Core/Portable/InitializeParameter/AbstractAddParameterCheckCodeRefactoringProvider.cs

src/EditorFeatures/CSharpTest/InitializeParameter/AddParameterCheckTests.cs

...atures/Core/Portable/InitializeParameter/AbstractAddParameterCheckCodeRefactoringProvider.cs

add localized text

Sliptory

done

Sliptory

need review

src/Workspaces/VisualBasic/Portable/CodeGeneration/VisualBasicSyntaxGenerator.vb

JoeRobich · 2020-04-20T17:50:29Z

src/Features/Core/Portable/FeaturesResources.resx

@@ -1460,6 +1460,16 @@ This version used in: {2}</value>
  <data name="Implement_explicitly" xml:space="preserve">
    <value>Implement explicitly</value>
  </data>
+  <data name="cannot_be_null_or_empty" xml:space="preserve">
+    <value>cannot be null or empty</value>


Please add a {0} place holder for replacement with the parameter name. Constructing this string with concatenation may not make sense for all languages.

CyrusNajmabadi · 2020-04-20T18:26:07Z

src/EditorFeatures/CSharpTest/InitializeParameter/AddParameterCheckTests.cs

@@ -330,17 +330,17 @@ public C(string a, string b, string c)
    {
        if (string.IsNullOrEmpty(a))
        {
-            throw new ArgumentException(""message"", nameof(a));
+            throw new ArgumentException($""'{nameof(a)}' cannot be null or empty"", nameof(a));


tests will fail on spanish leg if they reference english strings.

CyrusNajmabadi · 2020-04-20T18:26:43Z

src/Features/Core/Portable/FeaturesResources.resx

+  <data name="Struct_contains_assignment_to_this_outside_of_constructor_Make_readonly_fields_writable" xml:space="preserve">
+    <value>Struct contains assignment to 'this' outside of constructor. Make readonly fields writable</value>
+    <comment>{Locked="Struct"}{Locked="this"} these are C#/VB keywords and should not be localized.</comment>
+  </data>


why was this added?

CyrusNajmabadi · 2020-04-20T18:27:54Z

...atures/Core/Portable/InitializeParameter/AbstractAddParameterCheckCodeRefactoringProvider.cs

            return generator.ObjectCreationExpression(
                GetTypeNode(compilation, generator, typeof(ArgumentException)),
-                generator.LiteralExpression("message"),
+                generator.InterpolatedStringExpression(
+                    generator.CreateInterpolatedStringStartToken(false).WithLeadingTrivia(content.First().GetLeadingTrivia()),


named arg for false

the first/last content nodes won't have any trivia. so i don't know why w're taking trivia from them and adding to the interpolated string.

CyrusNajmabadi · 2020-04-20T18:28:34Z

src/Features/Core/Portable/xlf/FeaturesResources.cs.xlf

+        <source>{0} can be simplified</source>
+        <target state="translated">{0} se dá zjednodušit.</target>
+        <note />
+      </trans-unit>


why was this aded?

CyrusNajmabadi · 2020-04-20T18:29:13Z

@Sliptory If you'd like, we can pick up this PR from you and finish it. Thanks!

Sliptory · 2020-04-20T18:30:23Z

@Sliptory If you'd like, we can pick up this PR from you and finish it. Thanks!

Ok, Thanks!)

CyrusNajmabadi · 2020-04-20T18:32:32Z

@JoeRobich i can take this unless you wanted to :)

JoeRobich · 2020-04-20T18:40:53Z

@JoeRobich i can take this unless you wanted to :)

@CyrusNajmabadi Please, be my guest =)

CyrusNajmabadi · 2020-04-21T00:44:30Z

@JoeRobich this is ready for review. Thanks!

ghost

Auto-approval

CyrusNajmabadi · 2020-04-21T06:05:20Z

Thanks @Sliptory . Sorry that took so long :)

Sliptory added 3 commits March 2, 2020 23:06

fix issue dotnet#41822

693747a

fix

8af3602

additional fix

f1db60c

Sliptory requested a review from a team as a code owner March 2, 2020 20:41

delete static

472a2a8

jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Mar 4, 2020

jinujoseph assigned JoeRobich Mar 4, 2020

YairHalberstadt reviewed Mar 26, 2020

View reviewed changes

...atures/Core/Portable/InitializeParameter/AbstractAddParameterCheckCodeRefactoringProvider.cs Outdated Show resolved Hide resolved

YairHalberstadt reviewed Mar 26, 2020

View reviewed changes

src/EditorFeatures/CSharpTest/InitializeParameter/AddParameterCheckTests.cs Outdated Show resolved Hide resolved

CyrusNajmabadi reviewed Mar 26, 2020

View reviewed changes

...atures/Core/Portable/InitializeParameter/AbstractAddParameterCheckCodeRefactoringProvider.cs Outdated Show resolved Hide resolved

CyrusNajmabadi reviewed Mar 26, 2020

View reviewed changes

...atures/Core/Portable/InitializeParameter/AbstractAddParameterCheckCodeRefactoringProvider.cs Outdated Show resolved Hide resolved

CyrusNajmabadi reviewed Mar 26, 2020

View reviewed changes

...atures/Core/Portable/InitializeParameter/AbstractAddParameterCheckCodeRefactoringProvider.cs Outdated Show resolved Hide resolved

delete abstracts function from providers and add them in SyntaxGenerator

61f9b1e

add localized text

Sliptory requested a review from CyrusNajmabadi March 26, 2020 23:23

Sliptory added 2 commits March 27, 2020 02:26

Merge branch 'master' into Issue_#41822

d926470

add default statement

80112d9

Sliptory commented Mar 27, 2020

View reviewed changes

Sliptory commented Apr 2, 2020

View reviewed changes

Sliptory added 3 commits April 3, 2020 16:19

Merge branch 'master' into Issue_#41822

12396e5

Merge branch 'master' into Issue_#41822

3f6de0a

Merge branch 'master' into Issue_#41822

1ea005a

JoeRobich reviewed Apr 20, 2020

View reviewed changes

CyrusNajmabadi reviewed Apr 20, 2020

View reviewed changes

CyrusNajmabadi added 4 commits April 20, 2020 16:39

Merge remote-tracking branch 'upstream/master' into Issue_#41822

f2c6f4c

Properly generate interpolations

2662c8c

Fix

ce817d5

Fix

45228ff

JoeRobich approved these changes Apr 21, 2020

View reviewed changes

JoeRobich added the auto-merge label Apr 21, 2020

ghost approved these changes Apr 21, 2020

View reviewed changes

ghost merged commit 36bb0e5 into dotnet:master Apr 21, 2020

Sliptory deleted the Issue_#41822 branch April 21, 2020 09:02

JoeRobich added this to the 16.7 milestone Jul 30, 2020

JoeRobich mentioned this pull request Jul 30, 2020

Add IsNullOrEmpty or IsNullOrWhiteSpace check for method parameters throws an empty "message" #41822

Closed

sharwell modified the milestones: 16.7, 16.7.P1 Jul 30, 2020

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Issue #41822 Add IsNullOrEmpty or IsNullOrWhiteSpace check for method parameters throws an empty "message" #42101

Fix Issue #41822 Add IsNullOrEmpty or IsNullOrWhiteSpace check for method parameters throws an empty "message" #42101

Sliptory commented Mar 2, 2020

Sliptory left a comment

Sliptory left a comment

JoeRobich Apr 20, 2020

CyrusNajmabadi Apr 20, 2020

CyrusNajmabadi Apr 20, 2020

CyrusNajmabadi Apr 20, 2020

CyrusNajmabadi Apr 20, 2020

CyrusNajmabadi Apr 20, 2020

CyrusNajmabadi commented Apr 20, 2020

Sliptory commented Apr 20, 2020

CyrusNajmabadi commented Apr 20, 2020

JoeRobich commented Apr 20, 2020

CyrusNajmabadi commented Apr 21, 2020

ghost left a comment

CyrusNajmabadi commented Apr 21, 2020

Fix Issue #41822 Add IsNullOrEmpty or IsNullOrWhiteSpace check for method parameters throws an empty "message" #42101

Fix Issue #41822 Add IsNullOrEmpty or IsNullOrWhiteSpace check for method parameters throws an empty "message" #42101

Conversation

Sliptory commented Mar 2, 2020

Sliptory left a comment

Choose a reason for hiding this comment

Sliptory left a comment

Choose a reason for hiding this comment

JoeRobich Apr 20, 2020

Choose a reason for hiding this comment

CyrusNajmabadi Apr 20, 2020

Choose a reason for hiding this comment

CyrusNajmabadi Apr 20, 2020

Choose a reason for hiding this comment

CyrusNajmabadi Apr 20, 2020

Choose a reason for hiding this comment

CyrusNajmabadi Apr 20, 2020

Choose a reason for hiding this comment

CyrusNajmabadi Apr 20, 2020

Choose a reason for hiding this comment

CyrusNajmabadi commented Apr 20, 2020

Sliptory commented Apr 20, 2020

CyrusNajmabadi commented Apr 20, 2020

JoeRobich commented Apr 20, 2020

CyrusNajmabadi commented Apr 21, 2020

ghost left a comment

Choose a reason for hiding this comment

CyrusNajmabadi commented Apr 21, 2020