Port UseThrowExpression analyzer/fixer to shared layer #42264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
commented
Mar 8, 2020
| @@ -23,7 +29,7 @@ protected override bool IsSupported(ParseOptions options) | |||
| return csOptions.LanguageVersion >= LanguageVersion.CSharp7; | |||
| } | |||
|
|
|||
| protected override ISemanticFactsService GetSemanticFactsService() | |||
| => CSharpSemanticFactsService.Instance; | |||
| protected override bool IsInExpressionTree(SemanticModel semanticModel, SyntaxNode node, INamedTypeSymbol expressionTypeOpt, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
We can consider moving ISemanticFactsService down to shared analyzer layer, but it seems IsInExpressionTree is the only API from that service used in the IDE analyzers, so I have instead switched to directly invoking the extension method.
There was a problem hiding this comment.
can you add this to the lit of work. one of the primary reasons for ISyntax/SemanticFacts is so that we can take the direct questions like this out of the features and use a common mechanism.
I'm fine with this for now, but would def like to see it cleaned back up.
There was a problem hiding this comment.
I added porting ISemanticFactsService to shared analyzer layer to the follow-up work list in #41462 (comment)
CyrusNajmabadi
approved these changes
Mar 11, 2020
23 tasks
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit has source changes. Second commit has xlf file changes