Follow-up to #42323 #42713
Merged
Follow-up to #42323 #42713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid a binary break.
mavasani
commented
Mar 24, 2020
| @@ -17,8 +17,13 @@ internal static class CompletionOptions | |||
| // This is serialized by the Visual Studio-specific LanguageSettingsPersister | |||
| public static readonly PerLanguageOption2<bool> TriggerOnTyping = new PerLanguageOption2<bool>(nameof(CompletionOptions), nameof(TriggerOnTyping), defaultValue: true); | |||
|
|
|||
| public static readonly PerLanguageOption2<bool> TriggerOnTypingLetters = new PerLanguageOption2<bool>(nameof(CompletionOptions), nameof(TriggerOnTypingLetters), defaultValue: true, | |||
| public static readonly PerLanguageOption2<bool> TriggerOnTypingLetters2 = new PerLanguageOption2<bool>(nameof(CompletionOptions), nameof(TriggerOnTypingLetters), defaultValue: true, | |||
There was a problem hiding this comment.
Ensured that the name argument passed to the option constructor was not changed.
mavasani
commented
Mar 24, 2020
jasonmalinowski
approved these changes
Mar 24, 2020
| /// explicitly defines all the members from "IOption" type as "IOption" is not available in CodeStyle layer. | ||
| /// This ensures that all the sub-types of <see cref="IOption2"/> in either layer see an identical | ||
| /// set of interface members. | ||
| /// </summary> |
There was a problem hiding this comment.
Thanks, this is really helpful.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address pending PR feedback from #42323
Verified that the first commit resolves the binary breaking change for TS. This commit renames the completion options used by TS to have the
2suffix for internal use in Roslyn and restores the original option with public type for consumption by TS. Once TS moves to external access model, we can move the field with public type to TS layer, similar to the approach taken for all F# options.