Target-typed new: Add tests following review #42930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Feature - Target-Typed New
|
@AlekseyTs does that cover the scenarios you had in mind? |
|
@dotnet/roslyn-compiler Please review a small test-only change. Thanks |
cston
approved these changes
Apr 1, 2020
AlekseyTs
reviewed
Apr 7, 2020
| { | ||
| public void M2(C c) | ||
| { | ||
| c.M(new()); |
There was a problem hiding this comment.
new() [](start = 12, length = 5)
I think the interesting scenario is to test use-site diagnostics coming from the new, i.e. from the set of available constructors rather than form the set of available Ms.
There was a problem hiding this comment.
Sneaking test in another PR: 61ebdde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @alrz
Relates to #28489