[master] Update dependencies from dotnet/arcade #42959

dotnet-maestro · 2020-03-31T22:04:08Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: d7cf4206-186c-405a-0738-08d7d0ed8d73
Build: 20200331.8
Date Produced: 3/31/2020 7:29 PM
Commit: 778722af849c52ef9108c9927c19eaa4d6ebeb32
Branch: refs/heads/release/3.x
Updates:
- Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.20181.8

…331.8 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20181.8

dotnet-maestro · 2020-03-31T22:04:11Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests), roslyn-CI (Windows_Desktop_Unit_Tests debug_32)

ghost

Auto-approve

agocke · 2020-03-31T23:30:56Z

@tmat Any idea how to get more diagnostics here? I'm not sure what's going on.

dotnet-maestro · 2020-03-31T23:34:48Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests), roslyn-CI (Windows_Desktop_Unit_Tests debug_32)

tmat · 2020-04-01T00:07:04Z

The log says:

PDB0021: Document name doesn't match any pattern in Source Link: 'C:\Users\vsagent\.nuget\packages\microsoft.codeanalysis.performancesensitiveanalyzers\3.0.0-beta2.20169.3\build\PerformanceSensitiveAttribute.cs'

tmat · 2020-04-01T00:09:18Z

The source package doesn't come with a Source Link info.

dotnet-maestro · 2020-04-01T00:10:04Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests), roslyn-CI (Windows_Desktop_Unit_Tests debug_32)

tmat · 2020-04-01T00:11:34Z

@sharwell @mavasani We need to set IsSourcePackage to true in the project that builds microsoft.codeanalysis.performancesensitiveanalyzers package. Then double-check that Arcade generated Source Link targets to the package.

agocke · 2020-04-01T00:12:33Z

I admit, I don't really know what that means 🙃. It may be that that package was only included in source link in 5.0. Is there any way to exclude it? To prevent the build from complaining?

dotnet-maestro · 2020-04-01T00:15:07Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests), roslyn-CI (Windows_Desktop_Unit_Tests debug_32)

mavasani · 2020-04-01T00:17:18Z

Tagging @genlu for performance sensitive analyzers.

dotnet-maestro · 2020-04-01T00:20:10Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests), roslyn-CI (Windows_Desktop_Unit_Tests debug_32)

tmat · 2020-04-01T00:24:09Z

Ah, never mind. The package is adding the source file to EmbeddedFiles.

tmat · 2020-04-01T00:24:54Z

I think it's the validation in the Pdb2Pdb that's broken. I think I fixed it at some point though.

dotnet-maestro · 2020-04-01T00:25:12Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests), roslyn-CI (Windows_Desktop_Unit_Tests debug_32)

tmat · 2020-04-01T00:25:38Z

Here: dotnet/symreader-converter#162 and arcade version update here: dotnet/arcade#4125

dotnet-maestro · 2020-04-01T00:30:15Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests), roslyn-CI (Windows_Desktop_Unit_Tests debug_32)

agocke · 2020-04-01T00:33:09Z

@tmat Got it. Since we're moving "backwards" in Arcade, is it possible that's moving the symreader back as well?

dotnet-maestro · 2020-04-01T00:35:17Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests), roslyn-CI (Windows_Desktop_Unit_Tests debug_32)

tmat · 2020-04-01T00:40:28Z

Yes, it is.

dotnet-maestro · 2020-04-01T00:45:22Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration release_async), roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_Correctness_Test), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_CoreClr_Unit_Tests debug), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Unit_Tests debug_32), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests)

agocke · 2020-04-01T20:37:08Z

@tmat It looks like the compatible package version, 1.1.0-beta2-19516-01, doesn't exist in the dnceng feed, only on MyGet. Is there a way to add it to the dnceng feed?

dotnet-maestro · 2020-04-01T20:39:11Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration release_async), roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_Correctness_Test), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_CoreClr_Unit_Tests debug), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Unit_Tests debug_32), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests)

agocke · 2020-04-01T20:46:12Z

@markwilkie Is there any way to manually add a package to the feed? It looks like symbol publishing requires a version of Pdb2Pdb that isn't on the dnceng feed

dotnet-maestro · 2020-04-01T20:49:16Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration release_async), roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_Correctness_Test), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_CoreClr_Unit_Tests debug), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Unit_Tests debug_32), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests)

markwilkie · 2020-04-01T21:10:36Z

Should be possible. @JohnTortugo can probably help.

dotnet-maestro · 2020-04-01T21:14:28Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration release_async), roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_Correctness_Test), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_CoreClr_Unit_Tests debug), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Unit_Tests debug_32), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests)

tmat · 2020-04-01T21:32:28Z

@tmat It looks like the compatible package version, 1.1.0-beta2-19516-01, doesn't exist in the dnceng feed, only on MyGet. Is there a way to add it to the dnceng feed?

I don't understand. The latest version (1.1.0-beta2-20115-01) does not work?

dotnet-maestro · 2020-04-01T21:34:37Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-integration-CI (VS_Integration release_async), roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Unit_Tests debug_32), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests)

agocke · 2020-04-01T22:40:42Z

@tmat no, it looks newer versions don't accept the /verbose flag

dotnet-maestro · 2020-04-01T22:45:11Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: roslyn-integration-CI, roslyn-CI, roslyn-integration-CI (VS_Integration release_async), roslyn-integration-CI (VS_Integration debug_async), roslyn-CI (Windows_Correctness_Test), roslyn-CI (Windows_CoreClr_Unit_Tests release), roslyn-CI (Windows_CoreClr_Unit_Tests debug), roslyn-CI (Windows_Desktop_Unit_Tests release_64), roslyn-CI (Windows_Desktop_Unit_Tests release_32), roslyn-CI (Windows_Desktop_Unit_Tests debug_64), roslyn-CI (Windows_Desktop_Unit_Tests debug_32), roslyn-CI (Windows_Desktop_Spanish_Unit_Tests)

Update dependencies from https://github.com/dotnet/arcade build 20200…

6523e4f

…331.8 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20181.8

dotnet-maestro bot requested a review from a team as a code owner March 31, 2020 22:04

ghost approved these changes Mar 31, 2020

View reviewed changes

Use custom toolset compiler

c0f821b

Upgrade version of Pdb2Pdb used in build

542579e

Adjust Pdb2Pdb version and ErrorString name

3e5da30

dotnet-maestro bot requested a review from a team as a code owner April 1, 2020 22:07

agocke closed this Apr 2, 2020

agocke deleted the darc-master-ec12e34a-0f0e-4c56-9693-974ad75fe3a0 branch April 2, 2020 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[master] Update dependencies from dotnet/arcade #42959

[master] Update dependencies from dotnet/arcade #42959

dotnet-maestro bot commented Mar 31, 2020 •

edited

Loading

dotnet-maestro bot commented Mar 31, 2020 •

edited

Loading

ghost left a comment

agocke commented Mar 31, 2020

dotnet-maestro bot commented Mar 31, 2020 •

edited

Loading

tmat commented Apr 1, 2020

tmat commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020

tmat commented Apr 1, 2020 •

edited

Loading

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020

mavasani commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020

tmat commented Apr 1, 2020

tmat commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020

tmat commented Apr 1, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 1, 2020

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

tmat commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

markwilkie commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

tmat commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

[master] Update dependencies from dotnet/arcade #42959

[master] Update dependencies from dotnet/arcade #42959

Conversation

dotnet-maestro bot commented Mar 31, 2020 • edited Loading

From https://github.com/dotnet/arcade

dotnet-maestro bot commented Mar 31, 2020 • edited Loading

Auto-Merge Status

ghost left a comment

Choose a reason for hiding this comment

agocke commented Mar 31, 2020

dotnet-maestro bot commented Mar 31, 2020 • edited Loading

Auto-Merge Status

tmat commented Apr 1, 2020

tmat commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020

Auto-Merge Status

tmat commented Apr 1, 2020 • edited Loading

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020

Auto-Merge Status

mavasani commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020

Auto-Merge Status

tmat commented Apr 1, 2020

tmat commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020

Auto-Merge Status

tmat commented Apr 1, 2020 • edited Loading

dotnet-maestro bot commented Apr 1, 2020

Auto-Merge Status

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 • edited Loading

Auto-Merge Status

tmat commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 • edited Loading

Auto-Merge Status

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 • edited Loading

Auto-Merge Status

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 • edited Loading

Auto-Merge Status

markwilkie commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 • edited Loading

Auto-Merge Status

tmat commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 • edited Loading

Auto-Merge Status

agocke commented Apr 1, 2020

dotnet-maestro bot commented Apr 1, 2020 • edited Loading

Auto-Merge Status

dotnet-maestro bot commented Mar 31, 2020 •

edited

Loading

dotnet-maestro bot commented Mar 31, 2020 •

edited

Loading

dotnet-maestro bot commented Mar 31, 2020 •

edited

Loading

tmat commented Apr 1, 2020 •

edited

Loading

tmat commented Apr 1, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 1, 2020 •

edited

Loading