Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema for Syntax.xml #43378

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Add schema for Syntax.xml #43378

merged 2 commits into from
Apr 21, 2020

Conversation

AdamSpeight2008
Copy link
Contributor

@AdamSpeight2008 AdamSpeight2008 commented Apr 15, 2020

This enables intellisense support whilst editing this file.
Edit Implemented for both CSharp and Visual Basic

This enables intellisense support for this file.
@AdamSpeight2008 AdamSpeight2008 requested a review from a team as a code owner April 15, 2020 19:09
@CyrusNajmabadi
Copy link
Member

Can you do the same for C#?

@jcouv jcouv added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Apr 15, 2020
@jcouv jcouv self-assigned this Apr 21, 2020
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv merged commit d40d46d into dotnet:master Apr 21, 2020
@ghost ghost added this to the Next milestone Apr 21, 2020
@jcouv
Copy link
Member

jcouv commented Apr 21, 2020

Merged/squashed. Thanks @AdamSpeight2008 !

@sharwell sharwell modified the milestones: Next, temp, 16.7.P1 Apr 28, 2020
@AdamSpeight2008 AdamSpeight2008 deleted the patch-9 branch August 5, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants