Add hover support for razor lsp #43388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
added
Area-IDE
LSP
JoeRobich
approved these changes
Apr 15, 2020
jasonmalinowski
approved these changes
Apr 16, 2020
src/Features/LanguageServer/Protocol/Handler/Hover/HoverHandler.cs
Outdated
Show resolved
Hide resolved
TanayParikh
approved these changes
Apr 16, 2020
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back in support for hover for razor use cases. Note that liveshare is responsible for mirroring hover in cloud env due to lack of classification support in LSP hover. However, razor cannot use that, so we need to support through the roslyn lsp as well.
We can provide only through LSP once it supports classifications and we've implemented full quick info support - #43387