Enable ngen for codelens #43396
Merged
Enable ngen for codelens #43396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsienki
approved these changes
Apr 16, 2020
|
I'm fine with consuming the data for this. Equally, given that we've not been doing so far and RPS wasn't complaining, we could also just disable it from training? |
|
@chsienki looking at the history of this file, seems we intended to ngen this, just didn't have ibc data back then. That said, I'm fine either way. Exclude this from training would fix the missing data issue for sure :) Also, from the optprof profiling log, do you know what issues this might cause?
|
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think ngen should be enabled for this assembly, since we are profiling it. Also, not sure if this is somehow related to this issue
@chsienki @tmat