Remove some shims that were being used by Live Unit Testing #43411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyamnamboodiripad
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Yup I believe this is no longer used by LUT (or the BannedAPIAnalyzers would have reported it). I believe we now use Project.OutputPath directly since this now corresponds to the project's OutputPath msbuild property (whereas previously it used to correspond to IntermediateOutputPath which meant we had to use AbstractProject for this).
|
@shyamnamboodiripad, thanks for taking a look! That matches my memory as well as some cursory text searching in your repo. |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.