Document new conversions in general test plan #43427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Apr 17, 2020
| @@ -308,6 +308,8 @@ __makeref( x ) | |||
| - Interpolated string | |||
| - Tuple literal | |||
| - Tuple | |||
| - Default literal | |||
| - Implicit object creation | |||
There was a problem hiding this comment.
Consider putting (target-typed new) in here as well, as that's what we've been calling it.
There was a problem hiding this comment.
The reason I used that name is because the spec currently says "there is a new object creation conversion that is an implicit conversion from expression"
https://github.com/dotnet/csharplang/blob/master/proposals/target-typed-new.md
There was a problem hiding this comment.
Sure. But we call it target-typed new. I'm not saying remove the name, I'm just saying add a thing in parenthesis for ease of future reading.
333fred
approved these changes
Apr 18, 2020
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to add some recently added conversions to the test plan.