Don't hoist ref locals #43463
Don't hoist ref locals #43463
Conversation
|
Glad it worked :-) |
|
I poked around at some linked issues and didn't see others that seemed affected. I think this only resolves issues where either:
|
| "; | ||
|
|
||
| var comp = CreateCompilation(source, options: TestOptions.DebugDll); | ||
| comp.VerifyEmitDiagnostics(); |
There was a problem hiding this comment.
comp.VerifyEmitDiagnostics(); [](start = 12, length = 29)
Consider running the scenario and observing expected behavior at runtime. #Closed
| var comp = CreateCompilation(source, options: TestOptions.DebugDll); | ||
| comp.VerifyEmitDiagnostics(); | ||
| comp = CreateCompilation(source, options: TestOptions.ReleaseDll); | ||
| comp.VerifyEmitDiagnostics(); |
There was a problem hiding this comment.
comp.VerifyEmitDiagnostics(); [](start = 12, length = 29)
Here as well. #Closed
|
@RikkiGibson Here are some issues I had in mind:
They also involve ref locals in async methods, but those aren't crashes, so unlikely the same issue :-( |
| { | ||
| public async Task Step(Task<int> t) | ||
| { | ||
| ReadMemory() = await t; |
There was a problem hiding this comment.
Consider adding a test where we have a ref l-value and use a compound operator. Essentially
ReadMemory() += await t;
ghost
added this to the 
Closes #40251
@gafter could you please take a look? Without this change, we crash in debug mode, while giving the "expected" behavior (either giving an emit diagnostic or compiling successfully) in release mode.