Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SymbolAndProjectId #43483

Merged
merged 18 commits into from
Apr 21, 2020
Merged

Remove SymbolAndProjectId #43483

merged 18 commits into from
Apr 21, 2020

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Apr 19, 2020 •
edited
Loading

Followup to #43207. That PR makes it possible to just pass around symbols and determine which project they came from. Once we have that, we no longer need SymbolAndProjectId :)

Major points:

  1. SymbolAndProjectId is removed.
  2. Many methods which needed to pass a Project around are relaxed to just pass a Solution.

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners April 19, 2020 00:29
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Apr 20, 2020
Merged
@CyrusNajmabadi CyrusNajmabadi marked this pull request as draft April 20, 2020 22:02
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review April 21, 2020 01:00
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 21, 2020 01:00
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski this is ready for review.

@tmat
Copy link
Member

tmat commented Apr 21, 2020 

public struct SymbolCallerInfo

Nit for follow up: readonly struct

Refers to: src/Workspaces/Core/Portable/FindSymbols/SymbolCallerInfo.cs:18 in 10f383f. [](commit_id = 10f383f, deletion_comment = False)

tmat
tmat approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi
Copy link
Member Author

Nit for follow up: readonly struct

Will do!

@CyrusNajmabadi CyrusNajmabadi merged commit 43eeaf3 into dotnet:master Apr 21, 2020
@ghost ghost added this to the Next milestone Apr 21, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the allowSymbolOOPAndNoSymAndProjId branch April 21, 2020 20:38
@sharwell sharwell modified the milestones: Next, temp, 16.7.P1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.7.P1
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @tmat @sharwell