Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update System.Memory version #43515

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Update System.Memory version #43515

merged 2 commits into from
Apr 24, 2020

Conversation

Forgind
Copy link
Member

@Forgind Forgind commented Apr 20, 2020

This will be helpful in enabling solution filters in MSBuild.

@Forgind
Update System.Memory version
ed5899b 
This should automatically update System.Numerics.Vectors, which is needed by the MSBuild team to add a new dependency on System.Text.Json, which is used in adding support for solution filter files in MSBuild.
@Forgind Forgind requested a review from a team as a code owner April 20, 2020 20:31
tmat
tmat approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Forgind
Update System.Buffers version
dd5a2e0 
System.Memory depends on it being updated.
@jinujoseph jinujoseph added Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Apr 22, 2020
@Forgind
Copy link
Member Author

Forgind commented Apr 24, 2020

🥳

@tmat tmat merged commit 75b9ce9 into dotnet:master Apr 24, 2020
@ghost ghost added this to the Next milestone Apr 24, 2020
@Forgind Forgind deleted the memory-update branch April 25, 2020 00:42
@sharwell sharwell modified the milestones: Next, temp, 16.7.P1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.7.P1
Development

Successfully merging this pull request may close these issues.
4 participants
@Forgind @tmat @sharwell @jinujoseph