Allow enum preselection in Enum.HasFlag #43521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the VB TypeInferrer tests never actually asserted the resulting type is the type that we expected.
|
...e/LanguageServices/TypeInferenceService/AbstractTypeInferenceService.AbstractTypeInferrer.cs
Outdated
Show resolved
Hide resolved
...e/LanguageServices/TypeInferenceService/AbstractTypeInferenceService.AbstractTypeInferrer.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 20, 2020
jasonmalinowski
changed the title
jasonmalinowski
force-pushed
the
allow-enum-preselection-in-hasflags
branch
from
fe601e3 to
a2c2116
Compare
This allows enum completion to correctly offer the enum options immediately which is likely what the user is trying to do.
jasonmalinowski
force-pushed
the
allow-enum-preselection-in-hasflags
branch
from
a2c2116 to
f54cd3a
Compare
genlu
reviewed
Apr 21, 2020
| @@ -117,6 +117,12 @@ protected static IEnumerable<TypeInferenceInfo> GetCollectionElementType(INamedT | |||
|
|
|||
| return SpecializedCollections.EmptyEnumerable<TypeInferenceInfo>(); | |||
| } | |||
|
|
|||
| protected static bool IsEnumHasFlag(ISymbol symbol) | |||
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables preselection of the enum type if you're calling Enum.HasFlag:
@dpoeschl Any idea where the completion-level tests are of this? It seems Completion just defers to the type inferrer for what to preselect but I wasn't where we do testing for this.